Conversation
vshanthe
requested review from
Copilot,
ezilber-akamai and
yec-akamai
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a smoke test for the configure command and fixes flaky integration tests by adding proper retry logic and correcting test assertions. The changes improve test reliability by handling transient SSH connection issues and fixing incorrect header validation in the LKE node view test.
Changes:
- Added retry logic with 10 attempts for SSH connectivity test to handle transient failures
- Fixed incorrect header assertions in LKE node view test (split malformed string into proper header list and added missing pool_id)
- Added smoke test for
linode-cli configure --helpcommand
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration/ssh/test_ssh.py | Added subprocess import, .strip() calls for consistency, and retry logic for flaky SSH connectivity test |
| tests/integration/lke/test_clusters.py | Fixed malformed header list in test_view_node from single concatenated string to proper list with pool_id |
| tests/integration/account/test_account.py | Added smoke test for configure command help output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Test for configure and fix flaky tests
✔️ How to Test
make test-int TEST_CASE=test_account.py
make test-int TEST_CASE=test_clusters.py
make test-int TEST_CASE=test_ssh.py